Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use try-with-resource #322

Merged
merged 2 commits into from
Oct 21, 2021
Merged

Use try-with-resource #322

merged 2 commits into from
Oct 21, 2021

Conversation

offa
Copy link
Contributor

@offa offa commented Oct 21, 2021 •
edited
Loading

Usage of try-with-resource and a missing annotation; seems I've missed these.

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

basil
basil approved these changes Oct 21, 2021
View reviewed changes
Copy link
Member

@basil basil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

@basil basil added the internal label Oct 21, 2021
@basil basil merged commit c4c6b9d into jenkinsci:master Oct 21, 2021
@offa offa deleted the dev branch October 21, 2021 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@basil basil basil approved these changes

Assignees
No one assigned
Labels
internal
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@offa @basil