Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-64629] Fix uncaught exception for unauthorized users #277

Merged
merged 1 commit into from
Mar 2, 2021

Conversation

jvz
Copy link
Member

@jvz jvz commented Feb 16, 2021

When attempting to email a user with a locked, disabled, or otherwise unauthorized account, different types of AuthenticationException were not caught which would cause the mail to fail.

https://issues.jenkins.io/browse/JENKINS-64629

Related to similar update in jenkinsci/mailer-plugin#104

@jeffret-b @basil @jglick @l3ender

Copy link
Member

@jglick jglick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Close enough.

Copy link
Member

@basil basil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! I'll get a release of this out in the next few days. I'm going to first see if the users in the bug are willing to try an incremental build before I push this out to all users.

@l3ender
Copy link

l3ender commented Feb 16, 2021

@basil - I'm happy to help test an incremental build. We're currently using mailer plugin v1.32.1; I'm not sure how that plugin and this one (email-ext-plugin) are related. Our builds are freestyle and we use the "E-mail Notification" post-build action.

Let me know if I can assist--thanks!

@l3ender
Copy link

l3ender commented Feb 23, 2021

Can I help with testing or any release preparation?

@jvz
Copy link
Member Author

jvz commented Feb 23, 2021

Can I help with testing or any release preparation?

https://repo.jenkins-ci.org/incrementals/org/jenkins-ci/plugins/email-ext/2.82-rc1453.0cbb7237bf07/ has incremental releases you can try out.

@basil basil merged commit b21af71 into jenkinsci:master Mar 2, 2021
@basil basil added the bug label Mar 2, 2021
@basil
Copy link
Member

basil commented Mar 2, 2021

Released in 2.82.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants