Update Jenkins baseline, switch to jackson2-api, eliminate reflection, and test against latest LTS #264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jglick
approved these changes
Dec 8, 2020
| @@ -33,12 +33,12 @@ | |||
| <changelist>-SNAPSHOT</changelist> | |||
| <gitHubRepo>jenkinsci/email-ext-plugin</gitHubRepo> | |||
| <java.level>8</java.level> | |||
| <jenkins.version>2.164.3</jenkins.version> | |||
| <jenkins.version>2.222.4</jenkins.version> | |||
There was a problem hiding this comment.
FWIW https://www.jenkins.io/doc/developer/plugin-development/choosing-jenkins-baseline/ would recommend
Suggested change
| <jenkins.version>2.222.4</jenkins.version> | |
| <jenkins.version>2.222.1</jenkins.version> |
(I have reservations about that recommendation.)
There was a problem hiding this comment.
This needs to be 2.222.4 because a transitive dependency (org.jenkins-ci.plugins:credentials:jar:2.3.13) requires Jenkins 2.222.4 or higher.
There was a problem hiding this comment.
Right, the problem to my mind is lack of consistency in the ecosystem. You can feel free to backdate the version in credentials and it should be possible to get a quick release I guess.
Co-authored-by: Jesse Glick <jglick@cloudbees.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
jackson2-apiplugin rather than directly on Jackson as suggested in #229 (comment).Jenkinsfileto test against the latest LTS release.