Add additional debug logging when valid mail account cannot be found #258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See JENKINS-64095. #217 added more draconian enforcement of valid mail accounts. At least one user has encountered an invalid mail account and been unable to send mail. One possible area of concern is the check for
smtpUsername != null, which would erroneously classify a mail account with an empty (not null!) SMTP username as invalid. More generally, users need a way to debug invalid mail account failures. This change adds detailed debug logs covering mail account selection and mail account validation, with which a user who encounters an invalid mail account failure can get detailed information about what is wrong with their mail account.