Mark older fields as deprecated and migrate callers to non-deprecated equivalents #247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A number of fields were moved from
ExtendedEmailPublisherDescriptortoMailAccountat some point in the past. Most of the original getters and setters were then deprecated, but not all of them were. This change deprecates all of the original getters and setters and then updates any remaining callers to call the non-deprecated versions fromMailAccount.While I was here, I noticed that all references to
ExtendedEmailPublisherDescriptor#overrideGlobalSettingswere removed when JCasC support was added. This means we can dropoverrideGlobalSettingsfrom the serialized XML, so I've added thetransientkeyword to that field and deprecated its getter.