Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

private readResolve not honored by subtypes #220

Merged
merged 3 commits into from
Sep 30, 2020
Merged

private readResolve not honored by subtypes #220

merged 3 commits into from
Sep 30, 2020

Conversation

jglick
Copy link
Member

@jglick jglick commented Sep 30, 2020

Compatibility with jenkinsci/jenkins#4944.

jglick added a commit to jglick/jep that referenced this pull request Sep 30, 2020
@jglick
Linking to jenkinsci/email-ext-plugin#220
2be0e03
@jglick
Copy link
Member Author

jglick commented Sep 30, 2020

Was not able to reproduce ExtendedEmailPublisherTest failures from second build locally. Mailbox is empty? I noticed

java.lang.InterruptedException: sleep interrupted
	at java.lang.Thread.sleep(Native Method)
	at hudson.plugins.emailext.ExtendedEmailPublisherTest$SleepOnceBuilder.perform(ExtendedEmailPublisherTest.java:1307)
	at …

which might be related; Java unfortunately does not record a stack trace of the thread calling Thread.interrupt.

@jglick
Copy link
Member Author

jglick commented Sep 30, 2020

Possibly a flake; as of jenkinsci/plugin-pom@4569982 these are no longer retried in CI.

@slide
Copy link
Member

slide commented Sep 30, 2020

I restarted the build.

@jglick
Copy link
Member Author

jglick commented Sep 30, 2020

Now get some of the same failures, but not all of them.

@jglick
When using @ClassRule JenkinsRule, BuildWatcher is not helpful becaus…
6326661 
…e generated project types are meaningless; @rule TestName helps
@slide
Copy link
Member

slide commented Sep 30, 2020

Thanks for improving this!

@slide slide merged commit e8c4dfe into jenkinsci:master Sep 30, 2020
@jglick jglick deleted the xstream branch September 30, 2020 20:12
@jglick jglick restored the xstream branch September 30, 2020 20:13
@basil basil added the bug label Oct 22, 2020
@MRamonLeon
Copy link

@basil, @davidvanlaatum could you release these changes please?

@jglick jglick mentioned this pull request Oct 26, 2020
Merged
6 tasks
@basil
Copy link
Member

basil commented Oct 26, 2020

I'll try to get a release of this out sometime this week.

@basil
Copy link
Member

basil commented Oct 31, 2020

Released in 2.78.

@jglick jglick deleted the xstream branch November 2, 2020 14:15
jglick added a commit to jglick/jep that referenced this pull request Nov 2, 2020
@jglick
jenkinsci/email-ext-plugin#220 released
9b475bc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slide slide slide approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jglick @slide @MRamonLeon @basil