Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix JENKINS-63311 #213

Merged
merged 1 commit into from
Aug 5, 2020
Merged

Fix JENKINS-63311 #213

merged 1 commit into from
Aug 5, 2020

Conversation

slide
Copy link
Member

@slide slide commented Aug 5, 2020

Updated to check for isBlank rather than null for authentication

@slide
Fix JENKINS-63311
9dc907a 
Updated to check for isBlank rather than null for authentication
@slide slide merged commit e93a42d into jenkinsci:master Aug 5, 2020
@lukas9393
Copy link 

Sending email to: <e-mail>
MessagingException message: failed to connect, no password specified?

Line 325 has a negation, which should not be the case
so it should be StringUtils.isBlank(acc.getSmtpUsername() instead of !StringUtils.isBlank(acc.getSmtpUsername()

@slide
Copy link
Member Author

slide commented Aug 13, 2020

Sorry about that, #215

@slide slide deleted the fix_jenkins_63311 branch August 13, 2020 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@slide @lukas9393 @pcarenza