Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(updatecli): Use the native temurin source #905

Merged
merged 6 commits into from
Nov 27, 2024

Conversation

gounthar
Copy link
Contributor

@gounthar gounthar commented Nov 27, 2024

  • Enhanced JDK version bumping configurations for JDK 17 and JDK 21 thanks to the native temurin source
  • Removed outdated script for JDK verification to streamline processes.

Testing done

updatecli diff --debug --config ./updatecli/updatecli.d/jdk17.yaml --values ./updatecli/values.github-action.yaml 2>&1
updatecli diff --debug --config ./updatecli/updatecli.d/jdk21.yaml --values ./updatecli/values.github-action.yaml 2>&1

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@gounthar gounthar requested a review from a team as a code owner November 27, 2024 09:50
Copy link
Contributor

@dduportal dduportal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✔ Bump JDK17 version:
	Source:
		✔ [lastVersion] Get the latest Adoptium JDK17 version via the API
	Condition:
		✔ [checkTemurinAllReleases] Check if the "<lastVersion>" is available for all platforms
	Target:
		✔ [setJDK17VersionAlpine] Bump JDK17 default ARG version on Alpine Dockerfile
		✔ [setJDK17VersionDebian] Bump JDK17 default ARG version on Debian Dockerfile
		✔ [setJDK17VersionDockerBake] Bump JDK17 version for Linux images in the docker-bake.hcl file


✔ Bump JDK21 version for all Linux images:
	Source:
		✔ [latestJDK21Version] Get the latest Adoptium JDK21 version via the API
	Condition:
		✔ [checkTemurinAllReleases] Check if the "<latestJDK21Version>" is available for all platforms
	Target:
		✔ [setJDK21VersionDockerBake] Bump JDK21 version for Linux images in the docker-bake.hcl file

=> great work!

We can squash and merge

@dduportal dduportal merged commit c6fcec5 into jenkinsci:master Nov 27, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants