Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update for new header #194

Draft
wants to merge 22 commits into
base: main
Choose a base branch
from
Draft

Conversation

janfaracik
Copy link

@janfaracik janfaracik commented Feb 12, 2025

image image image

This is very (and I mean very) rough, want to get some thoughts on this early version for the new Jenkins header.

The thinking behind this PR is to minimise the need for completely overriding the header, instead relying on replaceable slots in core's header. This will make it easier to update core in the future, without risk of breaking/impacting this plugin.

I've also added some examples themes to the plugin, demonstrating it's customizability and also making it easy for users to revert to the classic header theme if they prefer.

Screenshot 2025-02-12 at 22 08 08

Still need to add the context aware logo.

Testing done

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@janfaracik janfaracik requested a review from a team as a code owner February 12, 2025 22:00
@janfaracik janfaracik marked this pull request as draft February 12, 2025 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant