[JENKINS-66639] adding explict jcasc symbol on CertificateCredentialImpl and UsernamePasswordCredentialsImpl classes #227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Unrelated changes in |
jglick
approved these changes
Sep 15, 2021
Vlatombe
reviewed
Sep 22, 2021
src/test/java/com/cloudbees/plugins/credentials/casc/CredentialsCategoryTest.java
Outdated
Show resolved
Hide resolved
…lsCategoryTest.java Co-authored-by: Vincent Latombe <vincent@latombe.net>
jglick
reviewed
Sep 28, 2021
| import hudson.Extension; | ||
| import hudson.ExtensionList; | ||
| import io.jenkins.plugins.casc.ConfigurationAsCode; | ||
| import io.jenkins.plugins.casc.misc.ConfiguredWithCode; | ||
| import io.jenkins.plugins.casc.misc.JenkinsConfiguredWithCodeRule; | ||
| import jcifs.util.Base64; |
There was a problem hiding this comment.
The trap of merging GitHub suggested changes 😄
There was a problem hiding this comment.
Or just SecretBytes.fromString ;)
|
(Will merge once CI passes) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.jenkins.io/browse/JENKINS-66639
For this specific feature, I have run test before and after adding the Symbol: both run are fine.