[JENKINS-73956] Extract inline event handlers from LegacyJobConfigMigrationMonitor/manage.jelly
#241
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.jenkins.io/browse/JENKINS-73956
Testing done
To activate the monitor I've installed the version of the plugin that does not have the fix for SECURITY-988, i.e. 1.43.1.
I've set up
src
job that doesecho 123 > file.txt
and archives the artifacts. Other jobs have Copy artifacts from another project step withsrc
being the project name to copy artifacts from.In security configuration I've enabled project based matrix auth strategy (from matrix-auth). I've added a user that has
Item.READ
andItem.BUILD
permissions. For thesrc
project that archives the artifact I've taken that permission away by enabling project-based security and setting "Do not inherit...". I've built all the jobs at least once, starting from thesrc
.After that I've upgraded the plugin to the latest version. Logged in as the user I've set up earlier and built the projects I had access to (all but
src
). That triggers the monitor. Logged back in as admin and navigated to/administrativeMonitor/copyArtifactLegacyJobConfigMigration/manage
.Before & after
Submitter checklist