Remove hard coded surefire config #199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the hard coded surefire config means it can not be overridden in CI or the CLI. Whilst forkCount is the most pressing - if unlimited threads really are used, that would seem like an issue for people on slow computers, or VMs with not a lot of CPU.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the hard coded surefire config means it can not be overridden in CI or the CLI.
Whilst forkCount is the most pressing - if unlimited threads really are used, that would seem like an issue for people on slow computers, or VMs with not a lot of CPU.
amends: #198
Testing done
checked https://ci.jenkins.io/blue/organizations/jenkins/Plugins%2Fcopyartifact-plugin/detail/PR-199/1/pipeline/70#step-88-log-892 is still running multiple tests in parallel
Submitter checklist