Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-65981] Fix thread leak with a static thread pool #82

Merged
merged 1 commit into from
Aug 22, 2022

Conversation

Dohbedoh
Copy link
Contributor

@Dohbedoh Dohbedoh commented Aug 18, 2022

Proposing a fix for JENKINS-65981 by making the ExecutorService static, with at least one thread and up to 5 threads by default (but configurable via system properties).

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@Dohbedoh
Copy link
Contributor Author

ping @jhansche

@jhansche jhansche merged commit d372040 into jenkinsci:master Aug 22, 2022
@jhansche
Copy link
Member

Thanks @Dohbedoh

@Dohbedoh Dohbedoh deleted the JENKINS-65981 branch August 23, 2022 01:50
@Dohbedoh
Copy link
Contributor Author

@jhansche the CD process did not create a release. We should probably add a label for bugfix and start it again. Could you help with this ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants