Clean up plugin #125
Merged
Clean up plugin #125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
basil
commented
Jun 19, 2023
Comment on lines
+33
to
+34
| <!-- TODO fix existing violations --> | ||
| <spotbugs.threshold>High</spotbugs.threshold> |
There was a problem hiding this comment.
Make SpotBugs error behavior the same locally as in CI, focusing on high-priority violations.
Comment on lines
-103
to
-106
| <dependency> | ||
| <groupId>org.jenkins-ci.plugins</groupId> | ||
| <artifactId>structs</artifactId> | ||
| </dependency> |
There was a problem hiding this comment.
Not needed as of recent cores.
Comment on lines
-138
to
-142
| <dependency> | ||
| <groupId>junit</groupId> | ||
| <artifactId>junit</artifactId> | ||
| <scope>test</scope> | ||
| </dependency> |
There was a problem hiding this comment.
Not needed as of recent plugin parent POMs.
Comment on lines
-279
to
-280
| if (!files.contains(file)) { | ||
| files.add(file.toVirtualFile()); |
There was a problem hiding this comment.
The only high-severity SpotBugs warning identified.
| @@ -48,7 +48,7 @@ | |||
| import org.kohsuke.stapler.QueryParameter; | |||
| import org.kohsuke.stapler.interceptor.RequirePOST; | |||
|
|
|||
| import javax.annotation.CheckForNull; | |||
There was a problem hiding this comment.
JSR 305 was EOL'ed a long time ago.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes the following unneeded JARs from the JPI:
commons-io-2.11.0.jar
commons-lang3-3.9.jar
jsr305-3.0.1.jar
slf4j-api-1.7.36.jar
JSR305 is deprecated and the other three are already bundled in Jenkins core, superseding the version bundled in any plugin JPIs.