Nicer error pages #2352
Merged
Nicer error pages #2352
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0fc7b35 to
12a1fcd
Compare
12a1fcd to
690edb0
Compare
timja
commented
Aug 28, 2023
| try { | ||
| get().configure(); | ||
| } catch (ConfiguratorException e) { | ||
| throw new ConfigurationAsCodeBootFailure(e); |
There was a problem hiding this comment.
This requires jenkinsci/jenkins#8442 to work properly although it won't do any harm if not present
|
@jenkinsci/configuration-as-code-plugin-developers / @jenkinsci/sig-ux any feedback on the error page? |
jglick
reviewed
May 8, 2024
| } | ||
| request.setAttribute("invalidAttribute", cause.getInvalidAttribute()); | ||
| request.setAttribute("validAttributes", cause.getValidAttributes()); | ||
| request.getView(ConfigurationAsCode.class, "error.jelly").forward(request, response); |
There was a problem hiding this comment.
FYI I am getting
java.lang.NullPointerException: Cannot invoke "javax.servlet.RequestDispatcher.forward(javax.servlet.ServletRequest, javax.servlet.ServletResponse)" because the return value of "org.kohsuke.stapler.StaplerRequest.getView(java.lang.Class, String)" is null
at io.jenkins.plugins.casc.ConfigurationAsCode.handleExceptionOnReloading(ConfigurationAsCode.java:207)
at io.jenkins.plugins.casc.ConfigurationAsCodeBootFailure.doDynamic(ConfigurationAsCodeBootFailure.java:17)
in CloudBees CI after a CasC error during startup. Not sure yet if this is reproducible.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2351
Before
After
Your checklist for this pull request
🚨 Please review the guidelines for contributing to this repository.