Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automatically request code reviews from all JCasC plugin developers #1249

Merged
merged 1 commit into from
Jan 18, 2020
Merged

Automatically request code reviews from all JCasC plugin developers #1249

merged 1 commit into from
Jan 18, 2020

Conversation

oleg-nenashev
Copy link
Member

@oleg-nenashev oleg-nenashev commented Jan 15, 2020 •
edited
Loading

Follow-up to the today's project meeting. After this change the @jenkinsci/configuration-as-code-plugin-developers team will be requested to review the changes. Now there are 9 team members, including former maintainers and contributors.

@oleg-nenashev oleg-nenashev added the chore a PR that adds to maintenance - used by Release Drafter label Jan 15, 2020
@oleg-nenashev oleg-nenashev requested review from a team, jetersen and timja January 15, 2020 22:40
@oleg-nenashev
Copy link
Member Author

I can also enable automatic review assignment, but the team would need a cleanup first.
image

@timja
Copy link
Member

timja commented Jan 15, 2020

I can also enable automatic review assignment, but the team would need a cleanup first.
image

O I didn't know this feature existed

@codecov
Copy link

codecov bot commented Jan 16, 2020

Codecov Report

Merging #1249 into master will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master    #1249   +/-   ##
=========================================
  Coverage     78.96%   78.96%           
  Complexity      780      780           
=========================================
  Files            65       65           
  Lines          2301     2301           
  Branches        321      321           
=========================================
  Hits           1817     1817           
  Misses          383      383           
  Partials        101      101

@jetersen
Copy link
Member

jetersen commented Jan 16, 2020 •
edited
Loading

I believe the team should be updated or there are certain members that should not be assigned. https://github.com/orgs/jenkinsci/teams/configuration-as-code-plugin-developers

jetersen
jetersen approved these changes Jan 16, 2020
View reviewed changes
Copy link
Member

@jetersen jetersen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, though I question the participants of some of the members as they are no longer actively working on the project.

@oleg-nenashev
Copy link
Member Author

I believe the team should be updated or there are certain members that should not be assigned.

Do not disagree, but we do not have a process for removing old maintainers. OTOH I can just reduce it to the list defined in https://github.com/jenkins-infra/repository-permissions-updater/blob/master/permissions/plugin-configuration-as-code.yml

@jetersen
Copy link
Member

Maybe just ping each person and ask if they want to be apart of the list.
I wonder if @ReleasePraqma should still be apart of the permissions.

@timja
Copy link
Member

timja commented Jan 16, 2020

Maybe just ping each person and ask if they want to be apart of the list.
I wonder if @ReleasePraqma should still be apart of the permissions.

They can also self leave if the notifications are annoying 🤷‍♂

@sladyn98
Copy link

Sounds like a good idea, would love to help as much as I can

@oleg-nenashev oleg-nenashev merged commit b68e82e into master Jan 18, 2020
@oleg-nenashev oleg-nenashev deleted the CODEOWNERS-team branch January 18, 2020 17:27
LinuxSuRen pushed a commit to alauda/configuration-as-code-plugin that referenced this pull request Feb 21, 2020
@v1v @jglick
@jetersen @oleg-nenashev @timja @dependabot-preview @MarkEWaite @jhonmike @dg-nvm @choeffer @fcojfernandez
Add backup casc config support (#6)
d8704c6 
* Add support to backup and restore automatically

* Fix the potential output resource leak

* Add configs about deploy into alauda update-center

* Set alauda as the main branch

* Add sonarqube properties file

* Fix the potentital issues

* Add a merge strategy extension point for the YAML config (#1)

* Add YAML merge strategy

* Add a new merge strategy

* Remove override merge strategy

* Clean the unused code lines

* Clean the unused imports

* Add test cases for merge strategy

* Fix the wrong test cases

* Take merge strategy name everytime

* Give the default strategy a more readable name

* Validate top README with the Integrations tests (jenkinsci#1229)

* Fix the compilation error caused by merge strategy

* Fix issues which found by spotbugs

* Remove unused imports

* Move profiles from pom.xml into settings file

* Remove empty line

* rename the shared-library

* Schema Generation for nested yml configurations (jenkinsci#1027)

* Trying to diagnose some flaky tests (jenkinsci#1243)

* Update ci to include code coverage after jenkinsci#1215 (jenkinsci#1241)

Co-authored-by: Oleg Nenashev <o.v.nenashev@gmail.com>

* Checkstyle ignore release.properties (jenkinsci#1245)

* [maven-release-plugin] prepare release configuration-as-code-1.35

* [maven-release-plugin] prepare for next development iteration

* Bump jackson.version from 2.10.1 to 2.10.2

Bumps `jackson.version` from 2.10.1 to 2.10.2.

Updates `jackson-databind` from 2.10.1 to 2.10.2
- [Release notes](https://github.com/FasterXML/jackson/releases)
- [Commits](https://github.com/FasterXML/jackson/commits)

Updates `jackson-dataformat-yaml` from 2.10.1 to 2.10.2
- [Release notes](https://github.com/FasterXML/jackson-dataformats-text/releases)
- [Commits](FasterXML/jackson-dataformats-text@jackson-dataformats-text-2.10.1...jackson-dataformats-text-2.10.2)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

* Correct spelling of hpi.pluginChangelogUrl tag (jenkinsci#1248)

* Automatically request code reviews from all JCasC plugin developers (jenkinsci#1249)

* [Security] Bump checkstyle from 8.26 to 8.29

Bumps [checkstyle](https://github.com/checkstyle/checkstyle) from 8.26 to 8.29. **This update includes a security fix.**
- [Release notes](https://github.com/checkstyle/checkstyle/releases)
- [Commits](checkstyle/checkstyle@checkstyle-8.26...checkstyle-8.29)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

* It has been renamed to `master.componentName` (jenkinsci#1256)

Co-authored-by: Tim Jacomb <t.jacomb@kainos.com>

* Fix the version specification for Jenkins 2.199 (jenkinsci#1268)

* Added example for credentials certificate (jenkinsci#1270)

* Use the latest shared-library branch

* Update test to match latest plugin version (jenkinsci#1273)

* Update the integration test for active-directory (jenkinsci#1274)

* Add integration test for pipeline-model-definition (jenkinsci#1276)

* Fix the error when no casc user dir (#5)

* Add missing of mode in the context

* Use the same version of jackson-core

* Use the same version of jackson-core

* Use 2.8 as the major version

* Fix the wrong parent id for the plugin releasing

* Move the user config into a backup dir

* Run build under java pod

Co-authored-by: Victor Martinez <victormartinezrubio@gmail.com>
Co-authored-by: Sladyn <sladynnunes98@gmail.com>
Co-authored-by: Jesse Glick <jglick@cloudbees.com>
Co-authored-by: Joseph Petersen <josephp90@gmail.com>
Co-authored-by: Oleg Nenashev <o.v.nenashev@gmail.com>
Co-authored-by: Tim Jacomb <t.jacomb@kainos.com>
Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
Co-authored-by: Mark Waite <mark.earl.waite@gmail.com>
Co-authored-by: Jhon Mike <jhon.msdev@gmail.com>
Co-authored-by: Dawid Gosławski <50369002+dg-nvm@users.noreply.github.com>
Co-authored-by: choeffer <33625292+choeffer@users.noreply.github.com>
Co-authored-by: Francisco Fernández <31063239+fcojfernandez@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sladyn98 sladyn98 sladyn98 approved these changes

@timja timja timja approved these changes

@jetersen jetersen jetersen approved these changes

Assignees
No one assigned
Labels
chore a PR that adds to maintenance - used by Release Drafter
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@oleg-nenashev @timja @jetersen @sladyn98