Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Schema Generation for nested yml configurations #1027
Schema Generation for nested yml configurations #1027
Changes from 1 commit
774506b
7051ca9
f1b2d30
17079c7
886bc5a
0271cd3
522f4e5
f264c70
076fe14
2bd7f9d
0da381b
3d45f6b
cd9a9dd
4bf306c
4657e0c
c734c0f
fe1ce60
8108038
38dad38
d89e24c
3c4510c
f079505
76c0932
623914f
13e893a
2ede6f6
ec07960
448c4a2
3165323
ad57f8d
14197bc
a338fbc
d0f9349
6c4cb3c
901ac01
4df5e1e
81b9a68
fd886c8
6c42055
b0b870b
fe7b0b8
dcd5f6f
122c8d9
e5bde57
b97f380
1e0a6a2
d0083d8
a030035
2b105a4
79892a2
51ae5fd
cee3cf6
1f72339
67c3f81
dff9199
5388f66
e992aee
0e9e3bd
5bacdd2
b07c22b
9bc089a
94e14d4
a96a4f7
802c9c9
d50ad6e
26341c4
3ce5e2b
b92032d
5e9ce85
a71b71e
ce565f2
cd01391
e50c94f
55e0216
80221ea
2ef14a3
53342bf
2403838
0395bea
30fdbf8
912b46d
603a577
d271135
896d2cb
ee1c946
6ab2a31
3e32f25
3be3926
e7b2a8f
314f1a7
b646a04
423ee6c
d5d10f4
1cdd881
1040a6a
a242048
0cfde4a
1aa84b1
1ff2aaf
15a7500
b468ee9
772445a
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
DescribeStructure would then no longer be needed as the describeForSchema would essentially perform the check.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we still need the mode var?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We would not need it in the
describeForSchema
anymore because ifisJsonSchema
is set then it would anyways be callingdescribeStructure
which would in turn calldescribeForSchema
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok please remove then
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done:+1: