-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[JENKINS-71789] Enable ${variable} support for email and cc fields #198
Conversation
ping @aheritier for review please! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM thanks @mikecirioli
please use |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All good. Thanks a lot !!!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm thanks
See JENKINS-71789 for reproducer and details
Advisor had default support for escaping
${VAR}
expressions in theemail
configuration field, but otherwise did not support resolving variables foremail
orcc
values, and would not correctly encode${VAR}
as{^${VAR}
if used as a CC value.This PR enables encode/decode support for the email and cc values fields.
Testing done
Submitter checklist