Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Store settings cookie for one year using YUI cookie utility #10

Closed
wants to merge 1 commit into from

Conversation

rborer
Copy link

@rborer rborer commented Sep 10, 2013

Here is a proposal to fix the issue of settings cookies that are session bound.

With this change, the settings (number of columns and font size) are persisted across browsers restart. The cookies remain 1 year after the last access, which should be sufficient (and can be easily modified).

It uses the core JS library provided by Jenkins to store the cookie content.

Let me know what you think of this fix.

Best regards,
Reynald

@jan-molak
Copy link
Member

Hi Reynald and thanks for the time you spent contributing to the project!
I'm on holidays at the moment, but I'll have a look at your pull request over the next two weeks and give you some feedback.

@jan-molak jan-molak closed this in 590792c Sep 28, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants