Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert latest copyartifact upgrade #2093

Closed

Conversation

MarkEWaite
Copy link
Contributor

@MarkEWaite MarkEWaite commented May 21, 2023

Update of copyartifact requires a newer version of the maven plugin. That would require bringing the maven plugin into the plugin bill of materials. That's not an attractive option. Will need to investigate possible changes in copyartifact to not require a newer version of the maven plugin.

This reverts commit fe7e570.

Testing done

Confirmed that the failing config file provider plugin tests are fixed by reverting this change.

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

Update of copyartifact requires a newer version of the maven plugin.
That would require bringing the maven plugin into the plugin bill of
materials.  That's not an attractive option.  Will need to investigate
possible changes in copyartifact to not require a newer version of the
maven plugin.

This reverts commit fe7e570.
@MarkEWaite MarkEWaite requested a review from a team as a code owner May 21, 2023 04:06
@MarkEWaite MarkEWaite added the bug Something isn't working label May 21, 2023
@MarkEWaite
Copy link
Contributor Author

MarkEWaite commented May 21, 2023

I would prefer to fix my mistake in the copyartifact plugin and release a new version of that plugin rather than downgrading the version with this revert.

jenkinsci/copyartifact-plugin#186 is the repair pull request that should deliver a new version once it merges.

@MarkEWaite
Copy link
Contributor Author

@MarkEWaite MarkEWaite closed this May 21, 2023
@MarkEWaite MarkEWaite deleted the revert-copyartifact-update branch May 21, 2023 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant