Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump jersey2-api from 2.38-1 to 2.39-1 in /bom-weekly #1794

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Feb 27, 2023

Bumps jersey2-api from 2.38-1 to 2.39-1.

Release notes

Sourced from jersey2-api's releases.

2.39-1

🚦 Tests

📦 Dependency updates

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot will merge this PR once CI passes on it, as requested by @jglick.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [jersey2-api](https://github.com/jenkinsci/jersey2-api-plugin) from 2.38-1 to 2.39-1.
- [Release notes](https://github.com/jenkinsci/jersey2-api-plugin/releases)
- [Commits](https://github.com/jenkinsci/jersey2-api-plugin/commits)

---
updated-dependencies:
- dependency-name: io.jenkins.plugins:jersey2-api
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot added dependencies Pull requests that update a dependency file java Pull requests that update Java code labels Feb 27, 2023
@dependabot dependabot bot requested a review from jglick February 27, 2023 23:02
Copy link
Member

@jglick jglick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dependabot squash and merge

@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Feb 27, 2023

One of your CI runs failed on this pull request, so Dependabot won't merge it.

Dependabot will still automatically merge this pull request if you amend it and your tests pass.

@jglick
Copy link
Member

jglick commented Feb 28, 2023

Failure looks legitimate. Not familiar enough with the library to know what it means offhand.

@MarkEWaite
Copy link
Contributor

jenkinsci/gitlab-plugin#1419 also reports an issue with the jersey2 api plugin 2.39-1 that was not visible with the jersey2 api plugin 2.38-1. I don't see anything to indicate that the failure in bom is directly related to the failure reported in the gitlab plugin, but both seem specific to the 2.39-1 release of jersey2 api.

@jglick
Copy link
Member

jglick commented Feb 28, 2023

This one FTR

RESTEASY003145: Unable to find a MessageBodyReader of content-type application/xml;charset=utf-8 and type class org.glassfish.jersey.JerseyTest$Employee

@MarkEWaite
Copy link
Contributor

This one FTR

RESTEASY003145: Unable to find a MessageBodyReader of content-type application/xml;charset=utf-8 and type class org.glassfish.jersey.JerseyTest$Employee

I'm seeing a stack trace related to MessageBodyReader when I run the tests locally with:

PLUGINS=jersey2-api bash local-test.sh

I'll do some deeper study later today to better understand what changed between jersey2 2.38 and jersey2 2.39.

@MarkEWaite
Copy link
Contributor

@dependabot close

Closing this pull request because there appears to be a breaking change in the Jersey 2.39 API from:

That pull request removed the no-args constructor on the DefaultJacksonJaxbJsonProvider class and added a constructor with the @Inject annotation and two arguments. It appears that RESTEasy needs the old constructor rather than the new constructor.

There may be an expectation that a class with an internal in its package name is not used by outside consumers like RESTEasy, but that expectation does not match with the behavior expected by RESTEasy client 3.15.3 (released Mar 5, 2021) as used by the current release of the Jenkins GitLab plugin.

I'm not yet sure how to create a case that will show the problem clearly to the Jersey maintainers. I will continue to explore ways to show that to them.

@dependabot dependabot bot closed this Feb 28, 2023
@dependabot dependabot bot deleted the dependabot/maven/bom-weekly/io.jenkins.plugins-jersey2-api-2.39-1 branch February 28, 2023 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file java Pull requests that update Java code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants