Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-75014] Allow auth module to see sts module classes #95

Merged
merged 1 commit into from
Dec 18, 2024

Conversation

basil
Copy link
Member

@basil basil commented Dec 18, 2024

Before this PR, I was seeing https://github.com/aws/aws-sdk-java-v2/blob/84b5a6cb7530eb332dec50581d8f490a23ca4531/core/auth/src/main/java/software/amazon/awssdk/auth/credentials/internal/WebIdentityCredentialsUtils.java#L49 which took me to https://github.com/aws/aws-sdk-java-v2/blob/84b5a6cb7530eb332dec50581d8f490a23ca4531/utils/src/main/java/software/amazon/awssdk/utils/ClassLoaderHelper.java#L124, showing that this code needs SetContextClassLoader to work with the Jenkins plugin class loading system.

Testing done

After this PR, could no longer reproduce the exception described in the issue description.

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@basil basil added the bug Something isn't working label Dec 18, 2024
@basil basil requested a review from a team as a code owner December 18, 2024 02:31
@basil basil merged commit c08280b into jenkinsci:master Dec 18, 2024
17 checks passed
@basil basil deleted the JENKINS-75014 branch December 18, 2024 05:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant