Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exposing Deployment-ID variable #12

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Exposing Deployment-ID variable #12

wants to merge 2 commits into from

Conversation

sams-gleb
Copy link

No description provided.

@sams-gleb sams-gleb closed this Feb 7, 2017
@sams-gleb sams-gleb reopened this Feb 7, 2017
Jmcfar
Jmcfar approved these changes Dec 19, 2017
View reviewed changes
Copy link
Collaborator

@Jmcfar Jmcfar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would also be good to include this variable name in the documentation for other users to find.

@Jmcfar
Copy link
Collaborator

Jmcfar commented Dec 19, 2017

Hi!

Thanks for the contribution.

Did you perform any testing as part of the changes? If so it'd be helpful to include that in the PR.

Are you OK with submitting this contribution under the Apache License 2.0?

@Jmcfar Jmcfar self-assigned this Dec 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jmcfar Jmcfar Jmcfar approved these changes

Assignees

@Jmcfar Jmcfar

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sams-gleb @Jmcfar