Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update XML namespace schemaLocation URL #685

Merged
merged 1 commit into from
Jan 1, 2024

Conversation

NotMyFault
Copy link
Member

While using the maven tidy plugin in another repository, I noticed that not only the POM has been tidied, but the XML namespace location has been changed too.

Given this is a trivial change because http://maven.apache.org/maven-v4_0_0.xsd redirects to https://maven.apache.org/xsd/maven-4.0.0.xsd, I'd propose we update it still, to align with the maven POM code convention and ensure future plugins use the up-to-date schema location URL.

@NotMyFault NotMyFault merged commit 04f9fae into jenkinsci:master Jan 1, 2024
2 checks passed
@NotMyFault NotMyFault deleted the update-schemaLocation branch January 1, 2024 21:53
@NotMyFault NotMyFault changed the title Update XML namespace schemaLocation Update XML namespace schemaLocation URL Jan 1, 2024
@basil
Copy link
Member

basil commented Jan 2, 2024

This theoretically implies a migration to bring a few hundred POM files up-to-date, though in practice it is unlikely to make any difference in behavior. This seems like the type of thing rewrite-jenkins should handle alongside e.g. https://github.com/openrewrite/rewrite-jenkins/blob/7dc30c8eda9495dfb7d3642f4139f33e78a9d817/src/main/java/org/openrewrite/jenkins/DisableLocalResolutionForParentPom.java.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants