Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to renovate for dependency management #603

Merged
merged 2 commits into from
Mar 10, 2023

Conversation

NotMyFault
Copy link
Member

When filing PRs like #596, I wondered if dependabot was just slow, because it didn't pick the directory up at all.
Screenshot 2023-03-10 at 15 38 18
Figured, dependabot expects a pom.xml here. Hence, there have been no automatic PRs before.

This PR replaces dependabot with renovate, which is fairly capable to update dependencies outside the typical build management files and paths. Hence, the config proposed is way smaller than the old dependabot one.

I requested an installation of renovate on this repository.

pom.xml Outdated Show resolved Hide resolved
basil
basil previously requested changes Mar 10, 2023
Copy link
Member

@basil basil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lacks a justification for why we would switch from a first-party GitHub platform component to a third-party tool.

Lacks a migration plan for migrating the entire Jenkins ecosystem to the proposed end state.

@timja
Copy link
Member

timja commented Mar 10, 2023

Lacks a migration plan for migrating the entire Jenkins ecosystem to the proposed end state.

This isn't updating the archetypes itself only this repository. Archetypes still use dependabot

@basil basil dismissed their stale review March 10, 2023 15:48

stale

@basil
Copy link
Member

basil commented Mar 10, 2023

Fine then, I do not object strongly but I am still weakly against this change.

@NotMyFault NotMyFault merged commit d43dc2e into jenkinsci:master Mar 10, 2023
@NotMyFault NotMyFault deleted the renovate branch March 10, 2023 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants