Add zh-CN translation for hello world as a localization demo #40
Conversation
|
@jenkinsci/code-reviewers |
|
I am not 100% sure it is supposed to wok in such way. IIUC it should go to https://github.com/jenkinsci/localization-zh-cn-plugin , CC @LinuxSuRen |
|
@oleg-nenashev |
|
In my opinions, perhaps there are two user cases: private or public plugin. If someone wants to create a public plugin (hosted in jenkinsci), then these localization files should be in ttps://github.com/jenkinsci/localization-zh-cn-plugin. Another case is the private plugin. They need to save these Chinese localization files in their plugin. |
This makes sense to me. |
|
@runzexia Do you still wish to make these changes? |
|
@LinuxSuRen I think I should add some comments, I forgot the PR before, I will deal with this part today. By the way, is the comment better in English or better in Chinese? |
|
My suggestion is using the Chinese comment. |
|
add comments |
...n/resources/archetype-resources/src/main/resources/HelloWorldBuilder/config_zh_CN.properties
Outdated
Show resolved
Hide resolved
|
This PR should have no problem, can someone help merge? |
| @@ -0,0 +1,6 @@ | |||
| # 如果您希望在 Jenkins 组织当中托管您的插件，那我们推荐您将本地化文件提交到 https://github.com/jenkinsci/localization-zh-cn-plugin 中。 | |||
| # 如果您希望私有维护插件，可以参考本例子的方式放置中文的本地化文件。 | |||
There was a problem hiding this comment.
Google Translate FTR:
If you wish to host your plugin in the Jenkins organization, we recommend that you submit your localization files to https://github.com/jenkinsci/localization-zh-cn-plugin.
If you want a private maintenance plugin, you can refer to this example to place the Chinese localization file.
No description provided.