Forward compatibility with jenkinsci/credentials-plugin#551

[janfaracik]

jenkinsci/credentials-plugin#551

Testing done

Submitter checklist

• Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
• Ensure that the pull request title represents the desired changelog entry
• Please describe what you did
• Link to relevant issues in GitHub or Jira
• Link to relevant pull requests, esp. upstream and downstream changes
• Ensure you have provided tests - that demonstrates feature works or fixes the issue

[timja]

(can ignore JiraPluginTest failing)

[basil]

when updating ATH tests for plugin changes, do we need to maintain compatibility with the old version of the plugin?

@janfaracik I think it is desirable to preserve compatibility unless it is prohibitively difficult. This PR passed against jenkinsci/credentials-plugin#551 but is failing on the current release of the Credentials plugin with

java.lang.IndexOutOfBoundsException: Index 1 out of bounds for length 0
	at java.base/jdk.internal.util.Preconditions.outOfBounds(Preconditions.java:64)
	at java.base/jdk.internal.util.Preconditions.outOfBoundsCheckIndex(Preconditions.java:70)
	at java.base/jdk.internal.util.Preconditions.checkIndex(Preconditions.java:266)
	at java.base/java.util.Objects.checkIndex(Objects.java:361)
	at java.base/java.util.ArrayList.get(ArrayList.java:427)
	at org.jenkinsci.test.acceptance.plugins.ssh_slaves.SshSlaveLauncher.addCredential(SshSlaveLauncher.java:39)
	at org.jenkinsci.test.acceptance.plugins.ssh_slaves.SshSlaveLauncher.pwdCredentials(SshSlaveLauncher.java:69)

In this case I think it would be relatively easy to support both cases with some sort of if/else or try/catch statement, so I think we should strive to preserve compatibility. See #1690 and #1693 for plenty of examples of how this was done before.

[janfaracik]

when updating ATH tests for plugin changes, do we need to maintain compatibility with the old version of the plugin?

@janfaracik I think it is desirable to preserve compatibility unless it is prohibitively difficult. This PR passed against jenkinsci/credentials-plugin#551 but is failing on the current release of the Credentials plugin with

java.lang.IndexOutOfBoundsException: Index 1 out of bounds for length 0
	at java.base/jdk.internal.util.Preconditions.outOfBounds(Preconditions.java:64)
	at java.base/jdk.internal.util.Preconditions.outOfBoundsCheckIndex(Preconditions.java:70)
	at java.base/jdk.internal.util.Preconditions.checkIndex(Preconditions.java:266)
	at java.base/java.util.Objects.checkIndex(Objects.java:361)
	at java.base/java.util.ArrayList.get(ArrayList.java:427)
	at org.jenkinsci.test.acceptance.plugins.ssh_slaves.SshSlaveLauncher.addCredential(SshSlaveLauncher.java:39)
	at org.jenkinsci.test.acceptance.plugins.ssh_slaves.SshSlaveLauncher.pwdCredentials(SshSlaveLauncher.java:69)

In this case I think it would be relatively easy to support both cases with some sort of if/else or try/catch statement, so I think we should strive to preserve compatibility. See #1690 and #1693 for plenty of examples of how this was done before.

Sure thing, updated.

[basil]

@janfaracik I'm getting the same java.lang.IndexOutOfBoundsException: Index 1 out of bounds for length 1 error on 2.480 in #1771