-
Notifications
You must be signed in to change notification settings - Fork 791
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: use newer kaniko image #7013
Conversation
fix jenkins-x#7012 Signed-off-by: Gazal K <mohamed.gazal@target.com.au>
Hi @gazal-k. Thanks for your PR. I'm waiting for a jenkins-x member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
I realise there's an effort to manage this in the version stream; #5063. But for now, this should help. |
There were some more references to the old release in this repository. In jx pipeline files. Wasn't sure whether I should change those |
/ok-to-test |
I have a good idea. Let's define environment variables to replace the kaniko image. |
Sorry, I prefer @abayer's suggestion of specifying the kaniko image version in the version stream. This is just an interim fix |
@abayer or anyone who has access to https://dashboard-jx.jenkins-x.live/teams/jx/projects/jenkins-x/jx/PR-7013/5, can you please share what's broken by this change. I checked the |
/retest It was just transient noise - rerunning. |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abayer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Thanks @abayer. Can someone (perhaps @jstrachan or @rawlingsj) please apply this on |
Signed-off-by: Gazal K mohamed.gazal@target.com.au
Submitter checklist
Description
Special notes for the reviewer(s)
Which issue this PR fixes
fixes #7012