Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use newer kaniko image #7013

Merged
merged 1 commit into from
Apr 5, 2020
Merged

Conversation

gazal-k
Copy link

@gazal-k gazal-k commented Apr 4, 2020

Signed-off-by: Gazal K mohamed.gazal@target.com.au

Submitter checklist

  • Change is code complete and matches issue description.
  • Change is covered by existing or new tests.

Description

Special notes for the reviewer(s)

Which issue this PR fixes

fixes #7012

fix jenkins-x#7012

Signed-off-by: Gazal K <mohamed.gazal@target.com.au>
@jenkins-x-bot
Copy link
Contributor

Hi @gazal-k. Thanks for your PR.

I'm waiting for a jenkins-x member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@gazal-k
Copy link
Author

gazal-k commented Apr 4, 2020

I realise there's an effort to manage this in the version stream; #5063. But for now, this should help.

@gazal-k
Copy link
Author

gazal-k commented Apr 4, 2020

There were some more references to the old release in this repository. In jx pipeline files. Wasn't sure whether I should change those

@abayer
Copy link
Contributor

abayer commented Apr 4, 2020

/ok-to-test

@nodece
Copy link

nodece commented Apr 4, 2020

I have a good idea. Let's define environment variables to replace the kaniko image.

@gazal-k
Copy link
Author

gazal-k commented Apr 4, 2020

I have a good idea. Let's define environment variables to replace the kaniko image.

Sorry, I prefer @abayer's suggestion of specifying the kaniko image version in the version stream. This is just an interim fix

@gazal-k
Copy link
Author

gazal-k commented Apr 4, 2020

@abayer or anyone who has access to https://dashboard-jx.jenkins-x.live/teams/jx/projects/jenkins-x/jx/PR-7013/5, can you please share what's broken by this change. I checked the jenkins-x-boot-vault.yml pipeline and it looks quite tricky for me to verify that on my machine

@abayer
Copy link
Contributor

abayer commented Apr 5, 2020

/retest

It was just transient noise - rerunning.

@abayer
Copy link
Contributor

abayer commented Apr 5, 2020

/lgtm

@jenkins-x-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abayer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jenkins-x-bot jenkins-x-bot merged commit d9a423c into jenkins-x:master Apr 5, 2020
@gazal-k gazal-k deleted the update-kaniko branch April 5, 2020 20:36
@gazal-k
Copy link
Author

gazal-k commented Apr 5, 2020

Thanks @abayer. Can someone (perhaps @jstrachan or @rawlingsj) please apply this on multicluster branch for jxl and update the jx version referenced in jxl

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

use new kaniko release
4 participants