Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add optional output to result #2

Merged
merged 10 commits into from
Mar 25, 2021
Merged

Conversation

timja
Copy link
Member

@timja timja commented Mar 25, 2021

@timja timja requested a review from jglick March 25, 2021 14:19
@timja timja added the enhancement New feature or request label Mar 25, 2021
Copy link
Collaborator

@jglick jglick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hard to follow. Needs careful testing in both original and new mode in a variety of scenarios. Unfortunately I never figured out how to set up a compelling test environment, so I just did live experiments on a low-risk plugin like log-cli.

run.sh Outdated Show resolved Hide resolved
run.sh Show resolved Hide resolved
run.sh Show resolved Hide resolved
run.sh Show resolved Hide resolved
@timja timja requested a review from jglick March 25, 2021 14:50
@timja
Copy link
Member Author

timja commented Mar 25, 2021

Hard to follow. Needs careful testing in both original and new mode in a variety of scenarios. Unfortunately I never figured out how to set up a compelling test environment, so I just did live experiments on a low-risk plugin like log-cli.

I tested it fairly extensively by just setting variables in my shell and running locally, adjusting the commit status as required / other vars

Copy link
Collaborator

@jglick jglick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So long as it is tested!

run.sh Show resolved Hide resolved
@timja
Copy link
Member Author

timja commented Mar 25, 2021

@jglick
Copy link
Collaborator

jglick commented Mar 25, 2021

Disinclination to debug this sort of thing is why I selected a strategy of the minimal number of steps per workflow to begin with. 😁

@timja
Copy link
Member Author

timja commented Mar 25, 2021

I was missing the ID in the action definition: b6ad93a

@timja timja merged commit 6dd04d9 into jenkins-infra:master Mar 25, 2021
@timja timja deleted the output-result branch March 25, 2021 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants