-
-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add optional output to result #2
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hard to follow. Needs careful testing in both original and new mode in a variety of scenarios. Unfortunately I never figured out how to set up a compelling test environment, so I just did live experiments on a low-risk plugin like log-cli
.
I tested it fairly extensively by just setting variables in my shell and running locally, adjusting the commit status as required / other vars |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So long as it is tested!
can either of you see what's wrong @garethjevans or @jglick: https://github.com/jenkinsci/jenkins-infra-test-plugin/runs/2195019274?check_suite_focus=true the output is evaluating to empty: |
Disinclination to debug this sort of thing is why I selected a strategy of the minimal number of steps per workflow to begin with. 😁 |
I was missing the ID in the action definition: b6ad93a |
cc @garethjevans