Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The release build sets
-Darguments
in various places in a futile attempt to reduce log spam, futile because that setting is ignored due to the presence of https://github.com/jenkinsci/jenkins/blob/d25704cfbc929bca3bd5e5675e1fe1aa1a58928c/pom.xml#L429, as one can see by looking at the actual console output and seeing the log spam. And furthermore, the presence of custom arguments anywhere (either via-Darguments
in the top-level Maven invocation or in themaven-release-plugin
configuration inpom.xml
) seems to break therelease:stage
goal in Maven Release Plugin 3.x as described in jenkins-infra/helpdesk#3143 (comment), so removing this dead code takes us one step closer toward working around the problem (the other step being removing the custom configuration inpom.xml
).