fix(buildDockerAndPublishImage) annotated tags #360
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes jenkins-infra/helpdesk#2887 by annotating the tag so it's an object itself with its date, and not just a reference attached to the last commit
dduportal
reviewed
Apr 20, 2022
lemeurherve
commented
Apr 20, 2022
|
Sounds good, great work! But before merging, do you mind trying this PR on https://github.com/jenkins-infra/docker-confluence-data? (e.g. add the annotation pointing to this PR on the main branch of https://github.com/jenkins-infra/docker-confluence-data, then kick a build of the main branch that is expected to add a new tag. This tag should be dated to today (and not to february). |
lemeurherve
added a commit
to jenkins-infra/docker-confluence-data
that referenced
this pull request
Apr 20, 2022
|
LGTM, previous tag: https://github.com/jenkins-infra/docker-confluence-data/releases/tag/0.0.40 (dated from February 24th), new one https://github.com/jenkins-infra/docker-confluence-data/releases/tag/0.0.41 dated from one minute ago |
|
Restarted another build, all good :) |
dduportal
reviewed
Apr 20, 2022
Co-authored-by: Damien Duportal <damien.duportal@gmail.com>
dduportal
approved these changes
Apr 20, 2022
lemeurherve
added a commit
to lemeurherve/pipeline-library
that referenced
this pull request
Jun 1, 2022
Co-authored-by: Damien Duportal <damien.duportal@gmail.com>
smerle33
pushed a commit
to smerle33/pipeline-library
that referenced
this pull request
Jan 16, 2024
Co-authored-by: Damien Duportal <damien.duportal@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes jenkins-infra/helpdesk#2887 by annotating the tag so it's an object itself with its date, and not just a reference attached to the last commit