Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --config parameter to specify pyproject.toml path #352

Merged
merged 12 commits into from
Mar 19, 2024

Conversation

glenrobertson
Copy link
Contributor

@glenrobertson glenrobertson commented Mar 12, 2024

Description

For projects that have a pyproject.toml config in a directory other than the root, this allows vulture to accept --config path/to/pyproject.toml (or -c path/to/pyproject.toml).

Related Issue

No issue created or found.

Checklist:

  • I have updated the documentation in the README.md file or my changes don't require an update.
  • I have added an entry in CHANGELOG.md.
  • I have added or adapted tests to cover my changes.
  • I have run pre-commit run --all-files to format and lint my code.

If you have a specific path to pyproject.toml in your project (e.g. not in the root), this allows `vulture` to read a config from that path.
@glenrobertson
Copy link
Contributor Author

@jendrikseipp I'm curious if you agree with this change? I found it useful in my project. If so, I can finish this up and do the checklist items.
Thanks!

Copy link
Owner

@jendrikseipp jendrikseipp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Yes, I like the suggested change.

vulture/config.py Outdated Show resolved Hide resolved
vulture/config.py Outdated Show resolved Hide resolved
glenrobertson and others added 3 commits March 14, 2024 13:25
Co-authored-by: Jendrik Seipp <jendrikseipp@gmail.com>
Co-authored-by: Jendrik Seipp <jendrikseipp@gmail.com>
@glenrobertson glenrobertson changed the title Add -c/--config parameter to specify pyproject.toml path Add --config parameter to specify pyproject.toml path Mar 14, 2024
@glenrobertson glenrobertson marked this pull request as ready for review March 14, 2024 18:19
Copy link
Owner

@jendrikseipp jendrikseipp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I only have two minor nitpicks.

README.md Outdated Show resolved Hide resolved
tests/test_config.py Outdated Show resolved Hide resolved
glenrobertson and others added 2 commits March 15, 2024 09:14
Co-authored-by: Jendrik Seipp <jendrikseipp@gmail.com>
@jendrikseipp jendrikseipp merged commit 9014a94 into jendrikseipp:main Mar 19, 2024
16 checks passed
@jendrikseipp
Copy link
Owner

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants