fix: apply reviews

jellyfin · Jan 28, 2023 · 474aace · 474aace
1 parent cff9c5b
commit 474aace
Show file tree

Hide file tree

Showing 5 changed files with 14 additions and 18 deletions.
diff --git a/frontend/locales/en-US.json b/frontend/locales/en-US.json
@@ -65,12 +65,12 @@
   "episodeNumber": "Episode {episodeNumber}",
   "errors": {
     "anErrorHappened": "An error happened",
+    "cantPlayItem": "This item can't be played",
     "messages": {
       "errorCode": "Error code: {errorCode}",
       "videoPlayerError": "The video player encountered an unrecoverable error."
     },
-    "unauthorized": "You're not authorized to access this page",
-    "cantPlayItem": "This item can't be played"
+    "unauthorized": "You're not authorized to access this page"
   },
   "failedRetrievingDisplayPreferences": "Unable to get display preferences. Using last known settings.",
   "failedSettingDisplayPreferences": "Unable to update display preferences.",

diff --git a/frontend/src/components/Layout/AudioControls.vue b/frontend/src/components/Layout/AudioControls.vue
@@ -50,7 +50,7 @@
                       :to="getItemDetailsLink(artist, 'MusicArtist')"
                       custom>
                       <span
-                        class="text--secondary text-caption text-truncate link"
+                        class="font-weight-light text-caption text-truncate link"
                         @click="navigate">
                         {{ artist.Name }}
                       </span>

diff --git a/frontend/src/components/Layout/TimeSlider.vue b/frontend/src/components/Layout/TimeSlider.vue
@@ -26,9 +26,9 @@ import { ticksToMs, formatTime } from '@/utils/time';
 const playbackManager = playbackManagerStore();
 const currentInput = ref(0);
 const clicked = ref(false);
-const runtime = computed(() => {
-  return ticksToMs(playbackManager.currentItem?.RunTimeTicks) / 1000;
-});
+const runtime = computed(
+  () => ticksToMs(playbackManager.currentItem?.RunTimeTicks) / 1000
+);
 const sliderValue = computed({
   get() {
     return clicked.value ? currentInput.value : playbackManager.currentTime;

diff --git a/frontend/src/components/Playback/PlayerElement.vue b/frontend/src/components/Playback/PlayerElement.vue
@@ -48,17 +48,17 @@ const mediaElement = computed<'audio' | 'video' | undefined>(() => {
 /**
  * If the player is a video element and we're
  */
-const teleportTarget = computed<'body' | '.video-container'>(() => {
-  return mediaElement.value === 'audio' ? 'body' : '.video-container';
-});
+const teleportTarget = computed<'body' | '.video-container'>(() =>
+  mediaElement.value === 'audio' ? 'body' : '.video-container'
+);
 
-const posterUrl = computed<string>(() => {
-  return !isNil(playbackManager.currentItem) && mediaElement.value === 'video'
+const posterUrl = computed<string>(() =>
+  !isNil(playbackManager.currentItem) && mediaElement.value === 'video'
     ? getImageInfo(playbackManager.currentItem, {
         preferBackdrop: true
       }).url || ''
-    : '';
-});
+    : ''
+);
 
 const isLoopingOnce = computed(
   () => playbackManager.repeatMode === RepeatMode.RepeatOne

diff --git a/frontend/src/store/items.ts b/frontend/src/store/items.ts
@@ -30,11 +30,7 @@ class ItemsStore {
    * == GETTERS ==
    */
   public getItemById = (id: string | undefined): BaseItemDto | undefined => {
-    return computed(() => {
-      if (id) {
-        return state.value.byId[id];
-      }
-    }).value;
+    return computed(() => (id ? state.value.byId[id] : undefined)).value;
   };
 
   public getItemsById = (ids: string[]): BaseItemDto[] => {