Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fast sync fix jellyfin/jellyfin-kodi#15 #18

Merged
merged 2 commits into from
Apr 23, 2019
Merged

fast sync fix jellyfin/jellyfin-kodi#15 #18

merged 2 commits into from
Apr 23, 2019

Conversation

jmeacoe
Copy link
Contributor

@jmeacoe jmeacoe commented Apr 12, 2019

…Added "Kodi Sync Queue" to plugins searched when attempting to use fast sync which now matches serverside.

Copy link
Contributor

@dtorner dtorner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you add the missing space before the new string?
I would like to get this pull merged, thanks jmeacoe.

@jmeacoe
Copy link
Contributor Author

jmeacoe commented Apr 14, 2019

Hey dtorner, I added the space, committed and pushed. Let me know if there is anything else you need me to do, as this is my first time working with git.

@dtorner
Copy link
Contributor

dtorner commented Apr 14, 2019

Well, I'm just a user with no admin rights like you, I just jumped in because I had the problem that this pull fixes. I hope an admin will review and approve it in case it is OK to be merged...

@cvium
Copy link
Member

cvium commented Apr 14, 2019

Honestly, I'd rather the plugin name check wasn't there at all. It should show an error if there's no endpoint listening instead.

@jmeacoe
Copy link
Contributor Author

jmeacoe commented Apr 14, 2019

I agree that there are better potential fixes but as it stands this issue is crippling the usability of the Kodi plugin and negating the jellyfin server plugin completely.
I believe this to be a good fix as a stop gap, and a new issue for improvement can be created, which I should be able to look into it a little later this week, but will take more time as I literally just applied the fix suggested in #15.

@cvium
Copy link
Member

cvium commented Apr 23, 2019

Approving as a stop-gap

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants