Removed connection tests and minor cleanup #145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcarlton00
approved these changes
Nov 15, 2019
|
|
||
| server_data = server.auth.get_server_info(server.auth.server_id) | ||
| server_address = server.auth.get_server_address(server_data, server_data['LastConnectionMode']) | ||
|
|
There was a problem hiding this comment.
Nit-picky extra new line here. No idea why it was there in the old version
There was a problem hiding this comment.
They are all like that so I just kept it the same as the rest
joshuaboniface
approved these changes
Nov 16, 2019
oddstr13
added a commit
to oddstr13/jellyfin-kodi
that referenced
this pull request
Dec 13, 2019
mcarlton00
added a commit
that referenced
this pull request
Dec 14, 2019
Add config migration for pr #145
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed the connection tests, and thus removed the functions which returned the appropriate address after changing the two places the addresses are set from their specific names to the generic 'address'
resolves #77