avformat/assenc: do not copy null terminator #509
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nyanmisaka
reviewed
Nov 26, 2024
|
If this is the cause, it would be nice to have the upstream add a sample to their fate-tests. |
|
The problem is I'm unable to reproduce with any of the files and handbrake combinations, the sample file I used for testing is binary edited to contain the null char. The sample file in the original ticket is no longer downloadable. |
The `par->extradata` buffer filled from some matroska files may be null terminated, and use `ffio_write_lines` using the full buffer length will copy this null character into the output files. This results in a file in which there is a null terminator after the header, but preceeding the actual content of the subtitle file. Treat this buffer as a string and write line with the text length of this buffer to skip the null character. Regression from 7bf1b9b
Exactly. Using those short links is terrible for archiving. |
Shadowghost
approved these changes
Nov 26, 2024
5 tasks
|
Merging as confirmed to fix the issue |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
par->extradatabuffer filled from some matroska files may be null terminated, and useffio_write_linesusing the full buffer length will copy this null character into the output files. This results in a file in which there is a null terminator after the header, but preceeding the actual content of the subtitle file. Treat this buffer as a string and write line with the text length of this buffer to skip the null character.Regression from 7bf1b9b
Fixes #506
Changes
Issues