-
-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Webpack watch and dev server scripts #97
Conversation
Is the webpack config large enough to warrant 4 files |
each file has a different purpose and keeps the options for each purpose in one place. I find it easier to grok this way but if you prefer it to be in one file with command line args i can do that :) |
@YouKnowBlom i've merged the configs down to one. Webpack 5 has a bunch of new stuff which makes this really neat :) also figured i'd change the config over to typescript seeing as the rest of the codebase is headed that way |
Awesome, I hope I didn't discourage you :p. Looks very neat now! Will take an extra look when I get home 👍 It's a busy time of the year so excuse me for taking a while to reply. |
all good mate - I've not looked at webpack 5 before this ticket so I just went with what I am familiar with, reading the docs really helped on one of my insomnia nights ;) all good on reply speed - this isnt our jobs ;) |
6570977
to
380a9ea
Compare
@simonmarklar Can you rebase this please? Last PR that converts everything to TS ^^. |
380a9ea
to
9bbc0d7
Compare
OK that should be all done. I'm not 100% sold on the webpack config being typescript, there was a few hoops to jump through. What's peoples thoughts? Its nice having the typings for config but it comes at a cost of several dev dependencies |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
plus my comment in jellyfinActions.ts, but I think I'm going to do a refactoring to async syntax later.
Would like changes for the two other comments if you agree with them.
- - removed eslint config that is automatically added by eslint-pligin-prettier
i dont want to refactor the code in There's a ton of refactoring that needs to be done to bring the code in line but IMHO we're better off doing focused PRs - plus i see so much in progress work and I know you're smashing things out so im willing to bet its already been done by someone :)
I dont think they are necessary - see my comments on them for more info :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for taking so long in getting this merged. Thank you very much for your contribution!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, I have gotten my questions answered. Would probably have preferred the promise resolve() to not be altered at all to make sure the linter still notes it as a problem. But that's very minor, especially with additional checks coming in that will cause us to rewrite away from promises 99% of cases
yarn serve
/yarn start
command using webpack dev serveryarn watch
for those using their own web serverpackage.json
uniformPlease note that while i've tested that it builds and launches/displays in a browser im still having issues with jellyfin detecting my chromecast so cant fully test :'(