-
-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DocumentManager #93
DocumentManager #93
Conversation
b826527
to
e365441
Compare
700f2cc
to
3c4f93e
Compare
Thanks for the review! I'll get back to it :) |
@simonmarklar I've done changes you suggested and I think I'm ready for another review :) |
dc2e63f
to
e2d0a24
Compare
29f6d68
to
d716363
Compare
7bdd489
to
676008f
Compare
Ready for reviews and regression testing! Afaik this should behave no differently from master |
@hawken93 Not strictly related to this PR but I think it fits to be added here: Right now we "render" the UI for all devices, even Chromecast Audios. Can you add a check here, so if the device is a Chromecast Audio, a |
Hmm I could try. I'm thinking to mess with the detection to make it think my gen2 is an audio for test |
@ferferga I've eased up the DOM operations on cc audio devices :) |
I have updated the style a bit. I think it looks good :) |
d6f2080
to
74c5d21
Compare
Okay @hamburglar2160 requesting new test, I've only deployed this PR right now. There have been a bunch of changes to UI since, so mostly UI related breakage may happen compared to nightly. @ferferga @simonmarklar new review? |
b0e0594
to
2ba05ae
Compare
I've modified waiting and details pages to use relative scaling, should make 4k display look the same as 720p display and I think it's for the better, @hamburglar2160 opinion? |
* @param {BaseItemDto} item to show information about | ||
* @returns {Promise<void>} for the page to load |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As far as I can see the hyphen is optional and just a readability thing, but from this I can fix the other one
* Removed the h2 text * Moved logo and h1 text to bottom left, logo inline * Add text bottom right to show the backdrop source * Slightly brighter backdrop
41959cb
to
c115262
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Assumming this was fully tested after the new changes, this LGTM
Making DocumentManager and taking the functions that deal with DOM in there.
Also fixed: