Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for jellyfinApi #338

Merged
merged 2 commits into from
Nov 8, 2022

Conversation

YouKnowBlom
Copy link
Contributor

Change JellyfinApi.setServerInfo parameters to accept null.
Add --silent to test command. This will silence output printed via console
Add check to remove leading slashes from path parameter in JellyfinApi.createImageUrl.
Add basic tests to JellyfinApi.
Change test environment to jsdom as that provides a more browser-like test environment.
Define RECEIVERVERSION globally for tests. Since we're not running the code through webpack, this variable will never be replaced and jest will get angry.

@YouKnowBlom YouKnowBlom marked this pull request as ready for review July 31, 2021 23:46
@nielsvanvelzen nielsvanvelzen merged commit 30e75e0 into jellyfin:master Nov 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants