-
-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make linting stricter and fix linting #106
Conversation
6c12852
to
cd477d7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, except my annoyance that I'd like the changes to go with the linting so that we're not buried deep in lint warnings.
Even before this there are some 260 linter warnings/errors and this will increase the errors even more. It will decrease the warnings some due to incomplete JSDoc but I'd rather have linter warnings than empty comment blocks. I think it's a bad thing that eslint even autofixes to empty comment blocks and params without types or descriptions, these should all be warnings too, but they are not.
In such a situation, new code may introduce more linter remarks, not less, because the linter loses its functionality as a mechanism to keep the code clean.
Also, if you know any checks to make sure public class members in typescript also have documentation, then I welcome this addition.
I understand that you may not be able to make good jsdoc comments, but in this regard we can prioritize not having any errors, and I'll fix jsdoc that requires knowing the code over time.
@hawken93 will do once we finish all the huge refactoring you did. Didn't want to mess with that until everything was in place 👍🏻. |
073b10a
to
c0b49e3
Compare
c0b49e3
to
be8d737
Compare
Using all the identation settings from Vue and fixed all the linting errors (warnings from JSDoc are still there) Most of the remaining earnings can be fixed as soon as we have proper typings with axios client. Marking as ready to review. |
56b2091
to
a272a7c
Compare
1449f2d
to
a0d4687
Compare
👍 |
This PR adds dependabot and extra linting settings to the ones added to #99. They are really similar to the ones enforced in Vue and Web
#99 must go first, as it adds extra packages needed for these settings to work, this PR just adds extra settings that are not related to the TS migration.