Remove GlobalScope interface and global $scope variable

jellyfin · Aug 1, 2021 · 89cfdae · 89cfdae
1 parent 0f62137
commit 89cfdae
Show file tree

Hide file tree

Showing 3 changed files with 1 addition and 11 deletions.
diff --git a/src/components/maincontroller.ts b/src/components/maincontroller.ts
@@ -26,7 +26,7 @@ import { getMaxBitrateSupport } from './codecSupportHelper';
 import { DocumentManager } from './documentManager';
 import { BaseItemDto } from '~/api/generated/models/base-item-dto';
 import { MediaSourceInfo } from '~/api/generated/models/media-source-info';
-import { GlobalScope, PlayRequest } from '~/types/global';
+import { PlayRequest } from '~/types/global';
 
 window.castReceiverContext = cast.framework.CastReceiverContext.getInstance();
 window.playerManager = window.castReceiverContext.getPlayerManager();

diff --git a/src/index.html b/src/index.html
@@ -7,11 +7,6 @@
             @import url('https://fonts.googleapis.com/css?family=Quicksand');
         </style>
         <script src="//www.gstatic.com/cast/sdk/libs/caf_receiver/v3/cast_receiver_framework.js"></script>
-        <script>
-            // $scope has to be available before app.js for webpack imported modules to function
-            // TODO: Rework this
-            $scope = {};
-        </script>
     </head>
     <body>
         <div id="waiting-container-backdrop"></div>

diff --git a/src/types/global.d.ts b/src/types/global.d.ts
@@ -6,10 +6,6 @@ import { SystemVolumeData } from 'chromecast-caf-receiver/cast.framework.system'
 import { RepeatMode } from '../api/generated/models/repeat-mode';
 import { BaseItemDto } from '../api/generated/models/base-item-dto';
 
-export interface GlobalScope {
-    [key: string]: any;
-}
-
 export interface Dictionary<T> {
     [Key: string]: T;
 }
@@ -94,7 +90,6 @@ interface SupportedCommands {
 declare global {
     export const PRODUCTION: boolean;
     export const RECEIVERVERSION: string;
-    export const $scope: GlobalScope;
     export interface Window {
         mediaElement: HTMLElement | null;
         playerManager: PlayerManager;