Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore missing files #108

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

egor-tensin
Copy link

@egor-tensin egor-tensin commented Jul 13, 2023

Summary

While playing with one of my Jekyll projects, I noticed that directories are not actually excluded from being watched if they're missing before jekyll serve is run (even though they're present in _config.yml's exclude array). As the example of .jekyll-metadata shows, it's possible to actually ignored missing directories; this PR attempts to implement this.

Testing

  • bundle exec rspec passes.

Before this fix, bundle exec rspec would fail a bunch of tests due to
the alternative config file names not being accounted for.
As the example of .jekyll-cache shows, it is possible to ignore missing
files/directories. However, they're currently filtered out; I don't quite
understand why. I found this limitation while playing with one of my
Jekyll projects and noticing that a directory added to "exclude" was not
ignored if it was created after `jekyll serve` is run.
@egor-tensin
Copy link
Author

A hopeless bump.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant