Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zsh-vi-mode breaks zsh-syntax-highlighting #228

Closed
3 tasks done
Jayden876212old opened this issue Jul 8, 2023 · 3 comments
Closed
3 tasks done

zsh-vi-mode breaks zsh-syntax-highlighting #228

Jayden876212old opened this issue Jul 8, 2023 · 3 comments
Assignees
Labels
bug Something isn't working verified This issue was already verified

Comments

@Jayden876212old
Copy link

Jayden876212old commented Jul 8, 2023

General information

  • Terminal program: Kitty
  • Operating system: Gentoo
  • ZSH framework: oh-my-zsh
  • ZSH version: 5.9
  • ZVM version: (not sure but it's the latest version according to oh-my-zsh)

Basic examination

  • I have read through the README page
  • I have the latest version of zsh-vi-mode
  • I have tested with another terminal program (I tested with alacritty aswell)

Problem description

Installing and setting zsh-vi-mode in my .zshrc breaks the plugin zsh-syntax-highlighting. Shown below is an example of a terminal command before and after setting zsh-vi-mode in my config.
Before:
image
After:
image

Reproduction steps

  1. Download and install zsh-vi-mode and zsh-syntax-highlighting.
  2. Enable them in your .zshrc like this:
plugins=(
	zsh-vi-mode
	zsh-syntax-highlighting
)
  1. Try typing a command with multiple arguments.

Expected behavior

The intended behaviour should be that different commands and arguments appear in their respective colours.
Like this:
image

@Ra1ze505
Copy link

Ra1ze505 commented Jul 9, 2023

i have this problem too 😢

  • Terminal program: iTerm2
  • Operating system: MacOS
  • ZSH framework: oh-my-zsh
  • ZSH version: 5.9

@jeffreytse jeffreytse self-assigned this Jul 9, 2023
@jeffreytse jeffreytse added bug Something isn't working verified This issue was already verified duplicate This issue or pull request already exists labels Jul 9, 2023
jeffreytse added a commit that referenced this issue Jul 9, 2023
This issue was caused by a bug which didn't invoke original function
after hooking the function. This bug also caused issues mentioned in
the #154 as well.
@jeffreytse jeffreytse removed the duplicate This issue or pull request already exists label Jul 9, 2023
@jeffreytse
Copy link
Owner

Hi @tdljayden,

I've fixed the issue you mentioned. Could you try the latest version? If you still got the issue, please let me know. And welcome to star this project for further update in the future. : )

Thanks & Regards

@Jayden876212old
Copy link
Author

Can confirm this works now. Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working verified This issue was already verified
Projects
None yet
Development

No branches or pull requests

3 participants