Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

3-letter month names change to full month names when iterating over May #227

Closed
3 tasks done
Hubro opened this issue Jul 7, 2023 · 0 comments
Closed
3 tasks done

3-letter month names change to full month names when iterating over May #227

Hubro opened this issue Jul 7, 2023 · 0 comments
Assignees
@jeffreytse
Labels
bug Something isn't working verified This issue was already verified

Comments

@Hubro
Copy link

Hubro commented Jul 7, 2023 •
edited by jeffreytse
Loading

General information

Please report the following information as possible as you can:

  • Terminal program: kitty 0.28.1
  • Operating system: Arch Linux
  • ZSH framework: none
  • ZSH version: 5.9
  • ZVM version: 2ca0cf6

Basic examination

  • I have read through the README page
  • I have the latest version of zsh-vi-mode
  • I have tested with another terminal program

Problem description

If you type out "Jan" and use Ctrla to increase it to "Feb", "Mar" and so on, once it reaches "May" it will assume you're iterating over full month names because "May" only has 3 letters. The next month will be "June" and so on.

Reproduction steps

See above ☝️

Expected behavior

It should probably somehow know that you're iterating over 3-letter month names, it will probably need to remember the last value to know that.
@jeffreytse jeffreytse self-assigned this Jul 7, 2023
@jeffreytse jeffreytse added bug Something isn't working verified This issue was already verified labels Jul 7, 2023
jeffreytse added a commit that referenced this issue Jul 11, 2023
@jeffreytse
fix: switching keywords on 3-letter month wrongly (#227)
75e828c 
The key month is `May`, as it's also 3-letter, to settle this issue,
we need to hold the switching history and to have a further checking.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jeffreytse jeffreytse

Labels
bug Something isn't working verified This issue was already verified
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Hubro @jeffreytse