Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ASUS changed something so now their cards are in stock when they are not #368

Closed
matjam opened this issue Sep 28, 2020 · 9 comments · Fixed by #1653
Closed

ASUS changed something so now their cards are in stock when they are not #368

matjam opened this issue Sep 28, 2020 · 9 comments · Fixed by #1653

Comments

@matjam
Copy link

matjam commented Sep 28, 2020

Description

https://store.asus.com/us/item/202009AM160000001/

Says "Coming Soon" but the bot is alerting every time saying it's in stock.

Possible solution

I think the page needs a second or two to finish loading. I see the initial "Add To Cart" button then it changes to "Coming Soon". Disabling javascript shows the "Add To Cart" button.

@matjam matjam added the bug label Sep 28, 2020
@matjam
Copy link
Author

matjam commented Sep 28, 2020

JS enabled:

image

JS disabled:

image

@jef jef removed the bug label Oct 1, 2020
@jef
Copy link
Owner

jef commented Oct 3, 2020

I've been getting 403s for Asus, but not this behavior.

Need more feedback from others to continue.

@Ghoddy
Copy link

Ghoddy commented Oct 6, 2020

I get the same thing, It says add to cart and then goes to arrival notice right after

@matjam
Copy link
Author

matjam commented Oct 6, 2020

I've been getting 403s for Asus, but not this behavior.

Need more feedback from others to continue.

The 403's are probably due to either VPN usage or your IP being banned. I get 403's from my work VPN.

Off the VPN, as of right now, if I search for 3080 on the asus store, I get no results.

Direct link to the current URL https://store.asus.com/us/item/202009AM160000001/ gives a 503.

They appear to have removed the cards from the store?

@jef
Copy link
Owner

jef commented Oct 10, 2020

your IP being banned

My IP is definitely banned. So I can't really do any testing here. If you have any fixes though, please feel free to create a PR. Sorry I can't be of much help.

@jef
Copy link
Owner

jef commented Oct 10, 2020

We have lables.inStock and labels.outOfStock, using both should help clear this up.

@jef jef closed this as completed Dec 8, 2020
@notjhoan
Copy link

Has there been a solution to this issue? I've been getting a few false positives for the dark hero with the exact same problem.

We have lables.inStock and labels.outOfStock, using both should help clear this up.

Where exactly could I find these to solve this? I've been getting 404s as well but have got a free trial VPN to try and fix it in the meantime.

@jef
Copy link
Owner

jef commented Jan 11, 2021

labels: {
inStock: {
container: '#item_add_cart',
text: ['add to cart']
}
},

@jef jef reopened this Jan 11, 2021
@jef
Copy link
Owner

jef commented Jan 11, 2021

Opening a PR for this fix now. Thanks!

jef added a commit that referenced this issue Jan 11, 2021
@jef jef closed this as completed in #1653 Jan 11, 2021
jef added a commit that referenced this issue Jan 11, 2021
erwinc1 pushed a commit to erwinc1/streetmerchant that referenced this issue Mar 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants