fix: disable redis if not configured

Fixes #1516
jef · Dec 26, 2020 · 6bc7737 · 6bc7737 · gianmarcotoso · Dec 26, 2020
1 parent 14998d8
commit 6bc7737
Showing 1 changed file with 13 additions and 7 deletions.
diff --git a/src/notification/redis.ts b/src/notification/redis.ts
@@ -1,17 +1,23 @@
 import {Link, Store} from '../store/model';
+import redis, {RedisClient} from 'redis';
 import {config} from '../config';
 import {logger} from '../logger';
-import redis from 'redis';
 
 const {url} = config.notifications.redis;
 
-const client = redis.createClient({
-	url
-});
+function initRedis(): RedisClient | null {
+	if (url) {
+		return redis.createClient({url});
+	}
+
+	return null;
+}
 
-const updateRedis = (link: Link, store: Store) => {
+function updateRedis(link: Link, store: Store) {
 	try {
-		if (url) {
+		const client = initRedis();
+
+		if (client) {
 			const key = `${store.name}:${link.brand}:${link.model}`
 				.split(' ')
 				.join('-');
@@ -35,6 +41,6 @@ const updateRedis = (link: Link, store: Store) => {
 	} catch (error: unknown) {
 		logger.error("✖ couldn't update redis", error);
 	}
-};
+}
 
 export default updateRedis;