Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(lib): make this library compatible with recent JAX versions #81

Merged
merged 2 commits into from
Sep 6, 2024

Conversation

jeertmans
Copy link
Owner

No description provided.

@jeertmans jeertmans added bug Something isn't working dependencies Pull requests that update a dependency file labels Sep 6, 2024
Copy link

codecov bot commented Sep 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (59cdf8f) to head (709d816).
Report is 22 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main       #81   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            9         9           
  Lines          976       978    +2     
=========================================
+ Hits           976       978    +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Sep 6, 2024

Benchmark results:

Benchmark before changes
accumulate_on_transmitters_grid_over_paths_noapprox 32.6 ms 33.9 ms: 1.04x slower
accumulate_on_transmitters_grid_over_paths_approx 37.7 ms 34.2 ms: 1.10x faster
path_method_image 42.7 us 336 us: 7.88x slower
path_method_FPT 77.3 us 377 us: 4.88x slower
path_method_MPT 108 us 413 us: 3.83x slower
Geometric mean (ref) 2.68x slower

@jeertmans jeertmans merged commit 8f31b52 into main Sep 6, 2024
15 of 16 checks passed
@jeertmans jeertmans deleted the fix-jax branch September 6, 2024 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant