Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(paper): permanent links and README intro #77

Merged
merged 2 commits into from
Jun 28, 2024
Merged

Conversation

jeertmans
Copy link
Owner

@jeertmans jeertmans added documentation Improvements or additions to documentation joss Related to the JOSS journal paper labels Jun 28, 2024
Copy link

codecov bot commented Jun 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (59cdf8f) to head (497dca2).
Report is 18 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main       #77   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            9         9           
  Lines          976       976           
=========================================
  Hits           976       976           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jeertmans jeertmans merged commit 8d3561d into main Jun 28, 2024
15 of 16 checks passed
@jeertmans jeertmans deleted the joss-review branch June 28, 2024 16:04
Copy link

github-actions bot commented Jun 28, 2024

Benchmark results:

Benchmark before changes
accumulate_on_transmitters_grid_over_paths_noapprox 34.9 ms 33.8 ms: 1.03x faster
path_method_image 43.7 us 43.0 us: 1.02x faster
path_method_FPT 78.5 us 78.0 us: 1.01x faster
Geometric mean (ref) 1.02x faster

Benchmark hidden because not significant (2): accumulate_on_transmitters_grid_over_paths_approx, path_method_MPT

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation joss Related to the JOSS journal paper
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant