Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(lib): add basic vertex diffraction #70

Merged
merged 11 commits into from
Jun 27, 2024
Merged

feat(lib): add basic vertex diffraction #70

merged 11 commits into from
Jun 27, 2024

Conversation

jeertmans
Copy link
Owner

No description provided.

@jeertmans jeertmans added the enhancement New feature or request label Jun 26, 2024
Copy link

github-actions bot commented Jun 26, 2024

Benchmark results:

Benchmark before changes
accumulate_on_transmitters_grid_over_paths_noapprox 33.0 ms 32.6 ms: 1.01x faster
path_method_image 42.2 us 42.5 us: 1.01x slower
path_method_FPT 77.0 us 77.6 us: 1.01x slower
Geometric mean (ref) 1.00x faster

Benchmark hidden because not significant (2): accumulate_on_transmitters_grid_over_paths_approx, path_method_MPT

Copy link

codecov bot commented Jun 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (ab6f9fb) to head (3c54745).
Report is 19 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main       #70   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            9         9           
  Lines          928       976   +48     
=========================================
+ Hits           928       976   +48     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jeertmans jeertmans merged commit 59cdf8f into main Jun 27, 2024
16 of 17 checks passed
@jeertmans jeertmans deleted the vertex branch June 27, 2024 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant