Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(docs): broken links and add check #68

Merged
merged 3 commits into from
Jun 27, 2024
Merged

fix(docs): broken links and add check #68

merged 3 commits into from
Jun 27, 2024

Conversation

jeertmans
Copy link
Owner

Closes #67

@jeertmans jeertmans added the documentation Improvements or additions to documentation label Jun 25, 2024
Copy link

codecov bot commented Jun 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (2cf5e77) to head (663ca5a).
Report is 25 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main       #68   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            9         9           
  Lines          928       928           
=========================================
  Hits           928       928           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Jun 25, 2024

Benchmark results:

Benchmark before changes
accumulate_on_transmitters_grid_over_paths_noapprox 32.5 ms 32.3 ms: 1.01x faster
path_method_FPT 77.1 us 77.3 us: 1.00x slower
path_method_MPT 108 us 108 us: 1.00x faster
Geometric mean (ref) 1.00x faster

Benchmark hidden because not significant (2): accumulate_on_transmitters_grid_over_paths_approx, path_method_image

@jeertmans jeertmans added the joss Related to the JOSS journal paper label Jun 26, 2024
@jeertmans jeertmans merged commit 53a83bb into main Jun 27, 2024
16 of 17 checks passed
@jeertmans jeertmans deleted the links-fix branch June 27, 2024 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation joss Related to the JOSS journal paper
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[DOC] Broken links in readme (JOSS Review)
1 participant